fix: use $index tracking in @for loops to prevent DST duplicate key e…#1795
Open
devchuckcamp wants to merge 1 commit intomattlewis92:mainfrom
Open
fix: use $index tracking in @for loops to prevent DST duplicate key e…#1795devchuckcamp wants to merge 1 commit intomattlewis92:mainfrom
devchuckcamp wants to merge 1 commit intomattlewis92:mainfrom
Conversation
…rrors During DST transitions, two consecutive local hours can map to the same UTC timestamp (e.g. 2 AM CET and 3 AM CEST both become 2024-03-31T01:00:00.000Z). The @for track expressions used .toISOString() which converts to UTC, causing NG0955 when daysInWeek spans a DST boundary. Replace all .toISOString() track expressions in the week view with $index. This is safe because views are fully recomputed on every input change. Fixes mattlewis92#1793
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During DST transitions, two consecutive local hours can map to the same UTC timestamp (e.g. 2 AM CET and 3 AM CEST both become 2024-03-31T01:00:00.000Z). The @for track expressions used .toISOString() which converts to UTC, causing NG0955 when daysInWeek spans a DST boundary.
Replace all .toISOString() track expressions in the week view with $index. This is safe because views are fully recomputed on every input change.
Fixes #1793